Add support for base in int()
#2338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
certik
approved these changes
Sep 27, 2023
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
I think that this is good. @Thirumalai-Shaktivel do you mind reviewing this as well?
Thanks @AkshayWarrier for the PR!
Thirumalai-Shaktivel
approved these changes
Sep 27, 2023
Collaborator
Thirumalai-Shaktivel
left a comment
Thirumalai-Shaktivel
left a comment
There was a problem hiding this comment.
Looks great, Thank you!
Contributor
Author
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2324
This might have some dependence on #1589 but looks like that PR hasn't made progress in a while
Pardon me if I've made obvious errors or the code isn't properly formatted but a review would be appreciated :)