-
Notifications
You must be signed in to change notification settings - Fork 171
Fixed scoping issues of for loops in global scope #2672
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
bc2e708
Fixed scoping issues of for loops in global scope
tanay-man 2ce5043
Covered subscripts
tanay-man 00d77ae
Considered edge case of nested list
tanay-man 6eed31f
Added white-spaces
tanay-man 764ebc6
Added integration test
tanay-man 4f2ffc4
Removed c backend from test loop_7
tanay-man 167d99c
Update src/lpython/semantics/python_ast_to_asr.cpp
tanay-man d516102
Split new test from loop_07 to loop_11 and others
tanay-man b5a92a9
Added print statements before assert
tanay-man 0b69fe2
Removed explicit cast to str
tanay-man File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
from lpython import i32 | ||
|
||
#checking for loops in the global scope | ||
sum: i32 = 0 | ||
i: i32 | ||
for i in [1, 2, 3, 4]: | ||
print(i) | ||
sum += i | ||
print("sum = ",sum) | ||
assert sum == 10 | ||
|
||
alphabets: str = "" | ||
c: str | ||
for c in "abcde": | ||
print(c) | ||
alphabets += c | ||
print("alphabets = ",alphabets) | ||
assert alphabets == "abcde" | ||
|
||
alphabets = "" | ||
s : str = "abcde" | ||
for c in s[1:4]: | ||
print(c) | ||
alphabets += c | ||
print("alphabets = ",alphabets) | ||
assert alphabets == "bcd" | ||
|
||
sum = 0 | ||
num_list : list[i32] = [1, 2, 3, 4] | ||
for i in num_list[1:3]: | ||
print(i) | ||
sum += i | ||
print("sum = ",sum) | ||
assert sum == 5 | ||
|
||
sum = 0 | ||
nested_list : list[list[i32]] = [[1, 2, 3, 4]] | ||
for i in nested_list[0]: | ||
print(i) | ||
sum += i | ||
print("sum = ",sum) | ||
assert sum == 10 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.