Sync #2854
Merged
Sync #2854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I also fixed the file_read after changes |
swamishiju
force-pushed
the
sync
branch
2 times, most recently
from
972dc4d to
e9403a9
Compare
swamishiju
force-pushed
the
sync
branch
2 times, most recently
from
bb5e69d to
0f80aee
Compare
swamishiju
force-pushed
the
sync
branch
2 times, most recently
from
76fca1b to
38a43b6
Compare
swamishiju
force-pushed
the
sync
branch
7 times, most recently
from
14b5f32 to
597b66b
Compare
certik
reviewed
Jun 24, 2025
certik
approved these changes
Jun 24, 2025
Contributor
certik
left a comment
certik
left a comment
There was a problem hiding this comment.
The missing parts are mostly string tests that we will have to rework anyway after we finish the string refactoring in LFortran.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest libasr sync
Almost all non-trivial data type tests (lists, dicts, etc) are commented out. I'll work on that before undrafting the PR