Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

@nykytenko
Copy link

No description provided.

@dnadlinger dnadlinger merged commit 58e91de into ldc-developers:ldc-ltsmaster Apr 28, 2016
@dnadlinger
Copy link
Member

Thanks for the patch!

Unfortunately, I had forgotten that the Solaris support pieces are also in upstream (DMD's) druntime, so I'll submit them there first and cherry-pick the patch back once it has been merged there.

@dnadlinger
Copy link
Member

Upstream PR: dlang#1551

You (@nykytenko) don't really need to do anything, I'll make sure it is merged upstream and trickles down into LDC.

@nykytenko
Copy link
Author

Thank, klickverbot.
Where i should add next druntime patch, in upstream (DMD's) druntime or in this ldc fork?

@dnadlinger
Copy link
Member

In general, we try to directly upstream everything that is applicable, as it makes merging in new frontend releases easier. Even if we might want to cherry-pick certain changes (e.g. platform support ones), being able to reference an upstream commit id makes making sense of merge conflicts much easier later on.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants