Skip to content

Implement @optStrategy UDA. #1637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kinke merged 1 commit into from
Jul 24, 2016
Merged

Implement @optStrategy UDA. #1637

kinke merged 1 commit into from
Jul 24, 2016

Conversation

@JohanEngelen
Copy link
Member

@JohanEngelen JohanEngelen commented Jul 23, 2016 •
edited
Loading

I need this for debugging so implemented it. Any alternative ideas for the name "optStrat"?

Resolves #1549.

druntime change: ldc-developers/druntime@1a71859

@kinke
Copy link
Member

kinke commented Jul 23, 2016

Thanks, makes a lot of sense. I'd prefer optStrategy to make clear we're not talking about optimization stratosphere or something. ;)

@JohanEngelen
Copy link
Member Author

JohanEngelen commented Jul 24, 2016

I changed the name to optStrategy.

@JohanEngelen JohanEngelen changed the title Implement @optStrat UDA. Implement @optStrategy UDA. Jul 24, 2016
@JohanEngelen
Copy link
Member Author

JohanEngelen commented Jul 24, 2016

Fixed merge conflict (because of druntime changes).

ready to merge?

kinke
kinke reviewed Jul 24, 2016
View reviewed changes
gen/uda.cpp Outdated
}
}

void applyAttrOptStrat(StructLiteralExp *sle, IrFunction *irFunc) {
Copy link
Member

@kinke kinke Jul 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OptStrategy here as well?

Copy link
Member Author

@JohanEngelen JohanEngelen Jul 24, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@kinke kinke merged commit e9f4ff2 into ldc-developers:master Jul 24, 2016
@JohanEngelen
Copy link
Member Author

JohanEngelen commented Jul 24, 2016

thanks!
(now on to the real bug then......)

@JohanEngelen JohanEngelen deleted the optnone branch July 24, 2016 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JohanEngelen @kinke