This repository was archived by the owner on Feb 12, 2023. It is now read-only.
Go modules #1
Merged
Go modules #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 24, 2016 09:29
dynflags: add dynamic JSON flag.
update inline docs
Flagset checksum and examples
Status endpoint
notifiers: add functions triggered on successful dyn flag sets
Endpoint checksum
monitoring: add a Prometheus collector for flagset checksums
The array is allocated with the same size as the map, instead of having the capacity of the map but size zero. This results in unintended leading empty string elements in the array.
Fix spurious leading spaces in output of DynStringSetValue.String().
Feature/kubernetes configmap
Feature: add option to read flags from file
- create go.sum - do not use .. in filenames in this repo due to golang/go#27299 Testing strategy: I almost successfully ran `test_all.sh` and found a data race, but I don't think it's related to this PR: ``` WARNING: DATA RACE Read at 0x00c00016cac0 by goroutine 29: github.com/spf13/pflag.(*FlagSet).VisitAll() /home/stefan/usr/go/main/pkg/mod/github.com/spf13/[email protected]/flag.go:277 +0x14a github.com/mwitkow/go-flagz.ChecksumFlagSet() /home/stefan/Projects/go-flagz/checksum.go:15 +0xc8 github.com/mwitkow/go-flagz/monitoring.(*flagSetCollector).Collect() /home/stefan/Projects/go-flagz/monitoring/collector.go:57 +0x2a2 github.com/prometheus/client_golang/prometheus.(*Registry).Gather.func1() /home/stefan/usr/go/main/pkg/mod/github.com/prometheus/[email protected]/prometheus/registry.go:434 +0x1eb Previous write at 0x00c00016cac0 by goroutine 28: github.com/spf13/pflag.sortFlags() /home/stefan/usr/go/main/pkg/mod/github.com/spf13/[email protected]/flag.go:204 +0x2f2 github.com/spf13/pflag.(*FlagSet).VisitAll() /home/stefan/usr/go/main/pkg/mod/github.com/spf13/[email protected]/flag.go:270 +0x1b0 github.com/mwitkow/go-flagz.ChecksumFlagSet() /home/stefan/Projects/go-flagz/checksum.go:15 +0xc8 github.com/mwitkow/go-flagz/monitoring.(*flagSetCollector).Collect() /home/stefan/Projects/go-flagz/monitoring/collector.go:55 +0xe9 github.com/prometheus/client_golang/prometheus.(*Registry).Gather.func1() /home/stefan/usr/go/main/pkg/mod/github.com/prometheus/[email protected]/prometheus/registry.go:434 +0x1eb ```
ldemailly
added a commit
that referenced
this pull request
Jul 12, 2020
This reverts commit 0dbd1d4.
Merged
ldemailly
added a commit
that referenced
this pull request
Jul 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getting the changes for modules in