Can I participate in development?

I made some stuff as addon for Blender that works in close cooperation with your LDR Importer adding things you didn't add, like automatic seam effect, repairing strange shadowing on sloped computer bricks that happens after your import, replacing nodes of material with nodes of color from external linked file instead of making new material (therefore there is no need to iterate thru all objects searching for a material and then replacing everyone of them, you just replace nodes from the material itself which leads to automatic change in every instance of the material in every object having it that is much quicker and better way), parrenting etc.

So my question is: if you will we can join our efforts and implement my stuff to your LDR Importer...hm?

[rioforce]

Hi and welcome! If you would like to contribute to our LDR Importer, all you need to do it Fork the repo, put your changes on the fork, and create a Pull Request. Your changes sound good so far (some of them I don't quite understand, but I probably will when I test them out! ;) )!

well, I would like to but I never did anything like that and I do not understand what exactly did you write :)
Fork?
repo?
Pull request?
See english is not my native language but if you could be so kind and be more specific...I would appriciate it

[rioforce]

Here's a little tutorial that may help you. :)

https://guides.github.com/activities/forking/

If you want, you can just paste your updated script in a code box by wrapping it with the <code></code> Tags in this box. Hope I could help!

So I made my fork...now where to put my code part as you were saying above,,hm? Is there some kind of "chat/forum" under my fork where I can paste it? Should I now click PULL REQUEST on right and paste my code there?

...or can I click that "+" creating new file, name it bublible.py and paste there bits of my code?

Because as I said my code come in a form of separate Blender addon and not as your updated importer file

[le717]

@bublible Here, I think these will help you out. https://guides.github.com/activities/hello-world/#branch https://github.com/le717/LDR-Importer/wiki/Contributing-to-LDR-Importer#getting-started ;)

Are your changes a separate script or actually a part of the importer? Going on what you said, it sounds like they were made in import_ldraw.py. In that case, simply take your version of the import script and overwrite the one already present.

Hey, it's no problem you are not sure what to do. This project has a tendency to attract new comers to git. 😉 I recommend reading all those GitHub Guides. They will definitely help you. ;)

@le717 no, it is separate .py file, addon for Blender that further improves your ldr importer ;)

Ah, I am kind of a super lazy person, so basically all I need to know now is WHERE CAN I PASTED MY CODE TO IT TO YOU GUYS? :) Everything else can wait, just to show you what you should add and how...of course only if you decide to do so...so, please tell me just where can I write it for you (I mean those main parts of my code)?

So if I understand what is written in the link you give me the only way I see is adding a new TEMPORARY FILE, let's name it bublible.py to the project and there I will put my code so you can check it, right?

• warning: actually I am FLASH ActionScript2 guy who can't stand anylonger all that empty wishes and prayers of eurobricks.com ppl for functions they have not in Blender so I becomes angry and frustrated that no one is going to do it for them so I look at Python syntax, its objects, scripting etc. and after like 2 weeks I was able quite easily...well not easily but anyway...to write all they were asking for and now offering this for your importer cos I thought it would be better to have it all in one addon instead of two :):):)

[le717]

OH! OK, I'm sorry. I was confused. My bad. We can get your fork set up later. 😉

Go to https://gist.github.com/, paste your code, name the file (give it a .py extension), save it (private Gist simply means only people with the link can view it), and paste the link here. We can see it that way.

Hey, that's fine. Python is a easy language to pick up. It's not an issue you are an AS2 scripter already. It doesn't really affect your Python skills (except maybe make it easier to learn since you already know how to "think like a programmer").

ok, let's work, ppl... :)

just a quick question: so should I save it as "Create Secret Gist", right?

• also, if you will,,I can post picture of BEFORE and AFTER my addon was applied, just tell me where to post those two pics for ya?

[le717]

It really doesn't matter which you do. Since you are pasting the link here in a public comment, people can technically still see a secret gist, but it will not seen in the All Gists feed.

Sure, why not. Just drag the two images into the comment box and they will be uploaded.

---

(I messed up the GIF 😛)

@le717 haha, no problem my friend, here the .jpg for comparison for you BEFORE and AFTER my addon

[le717]

Hey, that looks pretty good (including the render)! I'll let @rioforce comment on everything (he's a 3D artist, I'm a programmer :P), but I will say the brick seems looks to be similar to what was added in 92d510f.

Did you figure out how to create a Gist? I'd like to see how you performed these actions. :)

yea, I did, just being working on this pic now, so if you wait a bit more my code is on its way ;)

See, I do not know what was or was not added as I was not member of your "LDR Importer clan" :):):) ...therefor I did what I need tomhave not having it in official v1.1.5 that I downloaded

Also in my contingent is speckle or grain material for skew parts of sloped bricks but as I said rotation bug did not allow me to rotate replaced bricks as they should be so I commented that part of my code for a while now ;)

[rioforce]

Looks good so far! Can't wait to see the code! :)

Thanx, here it is + see my comment, and leave yours there let have it everything in one place, please ;)

• sorry for REPLACE COLOR commenting, it's in slovak,,my native language (I need tomcomment it that way to be able quickly react and not think twice what did I meant with the words :):):))

https://gist.github.com/bublible/cef2df27a5ff2d0d21c2