Resolve issue #267#283
Merged
seba-1511 merged 7 commits intolearnables:masterfrom Jan 21, 2022
nightlessbaron:master
Merged
Conversation
Contributor
Author
|
One more thing that can be added is a try-catch for the older version of torchvision. |
Member
|
Thanks for this PR @nightlessbaron! Yes, catching the exception for older versions is a good idea. Some more comments from a quick glance at the code:
Let me know when it's ready for a full review, and thanks again. |
Contributor
Author
|
@seba-1511, thanks for your review. I have incorporated the changes you suggested. |
Member
|
@nightlessbaron, this looks great and looks ready to merge -- thanks for persisting! Do you want to add a line to CHANGELOG.md and credit yourself? |
Contributor
Author
|
Thanks, @seba-1511, it's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #267
As discussed with @seba-1511, adds an option for RGB bands for Random Rotation.
Contribution Checklist
If your contribution modifies code in the core library (not docs, tests, or examples), please fill the following checklist.