Skip to content

Reformat code with Black #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Jul 12, 2021
Merged

Reformat code with Black #274

merged 16 commits into from
Jul 12, 2021

Conversation

mryab
Copy link
Member

@mryab mryab commented Jun 15, 2021

Adjusted the default configuration with 119 characters per line (this is the highest number allowed by GitHub PR view window).

Also, added pyproject.toml for configuring tools such as black/isort. However, compiling libp2p from scratch conflicts with the PEP517 build system backend, which is enabled by pyproject.toml: specifically, supplying build_py makes pip compile all dependencies from scratch (see pypa/pip#4118), which significantly increases the build time. To mitigate this issue, for now I supplied the --no-use-pep517 option to pip (see 5ef79da — without this change, the build works correctly, but we need to remove the timeout). This will likely be documented in #307, along with other considerations related to libp2p installation

@mryab mryab force-pushed the black_reformat branch 3 times, most recently from 0e14548 to 8043d35 Compare June 28, 2021 23:41
@codecov
Copy link

codecov bot commented Jun 29, 2021

Codecov Report

Merging #274 (f05083f) into master (4a33d1b) will decrease coverage by 0.08%.
The diff coverage is 77.56%.

@@            Coverage Diff             @@
##           master     #274      +/-   ##
==========================================
- Coverage   82.11%   82.02%   -0.09%     
==========================================
  Files          66       66              
  Lines        5893     5898       +5     
==========================================
- Hits         4839     4838       -1     
- Misses       1054     1060       +6     
Impacted Files Coverage Δ
hivemind/averaging/group_info.py 100.00% <ø> (ø)
hivemind/hivemind_cli/run_server.py 0.00% <0.00%> (ø)
hivemind/moe/server/connection_handler.py 45.83% <0.00%> (ø)
hivemind/optim/adaptive.py 77.77% <0.00%> (ø)
hivemind/optim/base.py 71.42% <0.00%> (ø)
hivemind/optim/performance_ema.py 28.00% <ø> (ø)
hivemind/utils/limits.py 25.00% <ø> (ø)
hivemind/optim/collaborative.py 26.20% <8.33%> (ø)
hivemind/moe/server/task_pool.py 43.16% <28.57%> (ø)
hivemind/moe/server/runtime.py 74.77% <33.33%> (ø)
... and 50 more

@mryab mryab force-pushed the black_reformat branch 2 times, most recently from dcb6c1b to 4473e32 Compare July 3, 2021 16:04
@mryab mryab requested review from justheuristic, borzunov and yhn112 and removed request for borzunov July 3, 2021 16:35
@mryab mryab marked this pull request as ready for review July 3, 2021 16:39
@mryab mryab requested review from borzunov and removed request for justheuristic July 3, 2021 16:43
@mryab mryab force-pushed the black_reformat branch 2 times, most recently from de66da1 to baa8a2f Compare July 10, 2021 14:59
@mryab mryab merged commit 2f07a55 into master Jul 12, 2021
@mryab mryab deleted the black_reformat branch July 12, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants