-
Notifications
You must be signed in to change notification settings - Fork 187
Reformat code with Black #274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0e14548
to
8043d35
Compare
Codecov Report
@@ Coverage Diff @@
## master #274 +/- ##
==========================================
- Coverage 82.11% 82.02% -0.09%
==========================================
Files 66 66
Lines 5893 5898 +5
==========================================
- Hits 4839 4838 -1
- Misses 1054 1060 +6
|
dcb6c1b
to
4473e32
Compare
de66da1
to
baa8a2f
Compare
borzunov
approved these changes
Jul 11, 2021
justheuristic
approved these changes
Jul 12, 2021
yhn112
approved these changes
Jul 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the default configuration with 119 characters per line (this is the highest number allowed by GitHub PR view window).
Also, added pyproject.toml for configuring tools such as black/isort. However, compiling libp2p from scratch conflicts with the PEP517 build system backend, which is enabled by pyproject.toml: specifically, supplying
build_py
makes pip compile all dependencies from scratch (see pypa/pip#4118), which significantly increases the build time. To mitigate this issue, for now I supplied the--no-use-pep517
option to pip (see 5ef79da — without this change, the build works correctly, but we need to remove the timeout). This will likely be documented in #307, along with other considerations related to libp2p installation