Fix deprecations and update dependencies for examples/albert #595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #595 +/- ##
==========================================
- Coverage 85.34% 85.30% -0.04%
==========================================
Files 81 81
Lines 8022 8022
==========================================
- Hits 6846 6843 -3
- Misses 1176 1179 +3 |
jmikedupont2
pushed a commit
to meta-introspector/hivemind
that referenced
this pull request
Mar 29, 2024
…g-at-home#595) * Install setuptools+wheel in develop mode during CI * Fix deprecations and update dependencies for examples/albert
mryab
added a commit
that referenced
this pull request
Oct 13, 2024
* Install setuptools+wheel in develop mode during CI * Fix deprecations and update dependencies for examples/albert (cherry picked from commit fdda330)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current Docker build fails due to old versions of transformers/datasets depending on an old version of tokenizers, which does not compile in the current environment of the Docker image. The easiest way to address the issue appears to be the bump of dependencies.
I have tested running the example on 2 peers with albert-base-v2, and the code runs and even starts to converge:
Also, in recent builds, pip started issuing an error when trying to pass --no-use-pep517 without setuptools and wheel installed (see this build as an example). This PR addresses the issue by installing setuptools and wheel before calling pip install.