Skip to content

Fixed testing, implemented validateLab #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 8, 2016

Conversation

cemersoz
Copy link

@cemersoz cemersoz commented Jul 8, 2016

No description provided.

@@ -0,0 +1,40 @@
var tuxlab = function(){}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This shouldn't be in collections. This should be in the /lab folder

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

labfiles reference the tuxlab module. we can either publish it to npm or force them to use a relative path. I figured forcing a ./tuxlab.js path would be easiest..
or, if you'd prefer I can manipulate lab strings to reference the correct file. i.e., instructors won't add import and export I'll just add it to the beginning and end of the string. Your call

@DerekTBrown DerekTBrown merged commit ac1aa2a into learnlinux:master Jul 8, 2016
DerekTBrown pushed a commit that referenced this pull request Jan 1, 2017
* issue 32 fixed

* removed swp

* fixed nconf issues

* issue 82, 84 fixes

* fixed #82

* isse #77

* fixed tests

* fixed files

* fixed tests master

* fixed comment

* moved validator

* removed duplicate file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants