Sentinel #10
Open
Sentinel #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
note, tsconfig.base.json as is, doesn't transpile import into request, which gives m problems when testing by hand. |
chayim
reviewed
Nov 14, 2023
| return { "host": data[3], "port": Number(data[5]) }; | ||
| } | ||
|
|
||
| export function createNodeList(data: any) { |
There was a problem hiding this comment.
There's a lot of any for typing here...
There was a problem hiding this comment.
yes, I dont know how to get typing out of raw redis commands yet.
chayim
reviewed
Nov 14, 2023
|
|
||
| for (const nodeData of data) { | ||
| const node = parseNode(nodeData) | ||
| if (node === undefined) { |
There was a problem hiding this comment.
undefined is like false in node - can we do an if/else here?
There was a problem hiding this comment.
what do you mean? in this case, I have parseNode return undefined for a node that is down, so can ignore it.
chayim
reviewed
Nov 14, 2023
chayim
reviewed
Nov 14, 2023
chayim
reviewed
Nov 14, 2023
| ); | ||
|
|
||
| export default class RedisSentinelMultiCommand<REPLIES = []> { | ||
| private static _createCommand(command: Command, resp: RespVersions) { |
There was a problem hiding this comment.
a lot of boilerplating - can this be done better
There was a problem hiding this comment.
copied/pasted from cluster object
+ don't need both sentinel client and pubsubclient + nits
returned by aquire() used by function passed to use()
1) it takes a lot of time now, so needs larger timeout 2) docker logs can be large, so need to increase maxBuffer size so doesn't error (and break test clean up)
+ provide API for other wrapper clients to also create invalid watch states programatically. Reasoning: if a user does a WATCH and then the client reconnects, the watch is no longer active, but if a user does a MULTI/EXEC after that, they wont know, and since the WATCH is no longer active, the request has no protection. The API is needed for when a wrapper client (say sentinel, cluster) might close the underlying client and reopen a new one transparently to the user. Just like in the reconnection case, this should result in an error, but its up to the wrapping client to provide the appropriate error
…type, some more cleanups
self -> _self change
though I realize this implementation, really only works after the first write command. unsure this is worth it.
no more semaphore type counting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testpass with this change (including linting)?