This repository was archived by the owner on Jan 18, 2025. It is now read-only.
infinite refresh redirection issue fix#151
Open
nikeshakya wants to merge 1 commit intoleonardocardoso:mainfrom
Open
infinite refresh redirection issue fix#151nikeshakya wants to merge 1 commit intoleonardocardoso:mainfrom
nikeshakya wants to merge 1 commit intoleonardocardoso:mainfrom
Conversation
-> before fetching meta heads, removed any comment lines to ensure validy of tags -> restricted redirection if title meta is present, assuming first fetched data has required information to fill up Response object -> made sure redirect recursion only loops one time for faster response from completion -> restricted max length of html string for faster performance, assuming meta tags are all available within half of the page
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-> before fetching meta heads, removed any comment lines to ensure validy of tags
-> restricted redirection if title meta is present, assuming first fetched data has required information to fill up Response object
-> made sure redirect recursion only loops one time for faster response from completion
-> restricted max length of html string for faster performance, assuming meta tags are all available within half of the page
hope fixed #139