Make CAA checking more like DCV checking #8491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beautifulentropy
approved these changes
Nov 18, 2025
aarongable
requested review from
a team and
jsha
and removed request for
a team
jsha
requested changes
Nov 21, 2025
jsha
approved these changes
Nov 21, 2025
npurtova
pushed a commit
to plesk/boulder
that referenced
this pull request
Nov 25, 2025
If the primary perspective CAA check returns an error, return early rather than always kicking off the remote checks anyway. As part of this change, rearrange the code in DoCAA to more closely mirror the code in DoDCV. In particular, move the creation of the result protobuf into a helper function which can be called at both the early-return and late-return locations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the primary perspective CAA check returns an error, return early rather than always kicking off the remote checks anyway.
As part of this change, rearrange the code in DoCAA to more closely mirror the code in DoDCV. In particular, move the creation of the result protobuf into a helper function which can be called at both the early-return and late-return locations.