sfe: Keep loading intervals in sync with promise, fix wording #8500
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprenken
approved these changes
Nov 20, 2025
jprenken
requested review from
a team and
jsha
and removed request for
a team
aarongable
approved these changes
Nov 21, 2025
Contributor
aarongable
left a comment
aarongable
left a comment
There was a problem hiding this comment.
Adding these cross-referential comments is great. But we haven't given ourselves any margin for error here. If we want to commit to 30 minutes, we should refresh more often than that. If we want to refresh every 30 minutes, we should only commit to a few hours.
Member
Author
Noted, I'll ship something else up for that. I'd like to get this over the line. |
beautifulentropy
deleted the
ratelimit-overrides-reload-intervals-sync
branch
npurtova
pushed a commit
to plesk/boulder
that referenced
this pull request
Nov 25, 2025
…crypt#8500) Small comments to keep these three areas of our code in sync. Small fix to wording; not all of our limits are for a 1 week period.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small comments to keep these three areas of our code in sync. Small fix to wording; not all of our limits are for a 1 week period.