sa: Fix modelToOrder to populate V2Authorizations from Authzs column #8514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In letsencrypt@978877a35 ("Store authzIDs directly in order table"), the modelToOrder function was updated to decode the new Authzs protobuf column, but the decoded values were never assigned to the order's V2Authorizations field. This caused the StoreAuthzsInOrders feature to not work correctly for reads. The bug meant that even with StoreAuthzsInOrders enabled: 1. Reads always fell back to querying the orderToAuthz2 table 2. The Authzs blob was parsed but the result was discarded 3. Eventually dropping orderToAuthz2 would break all order reads The fix assigns the decoded authz IDs to V2Authorizations, allowing orders with the new column populated to skip the fallback query. Also adds TestModelToOrderAuthzs to verify the fix and prevent regression.
aarongable
previously approved these changes
Dec 8, 2025
sa/model_test.go
Outdated
Comment on lines
254
to
255
| test.AssertNotError(t, err, "modelToOrder failed") | ||
| test.AssertDeepEquals(t, order.V2Authorizations, tc.expectedAuthzIDs) |
Contributor
There was a problem hiding this comment.
nit: we're preferring to follow the Go style guide's advice regarding test assertions in new tests. Making these look more like
if err != nil {
t.Fatalf("modelToOrder(%v) = %s, want success", tc.model, err)
}
if !slices.Equal(order.V2Authorizations, tc.expectedAuthzIDs) {
t.Errorf("modelToOrder(%v) = %v, want %v", tc.model, order.V2Authorizations, tc.expectedAuthzIDs)
}would be preferable.
aarongable
approved these changes
Dec 8, 2025
jsha
approved these changes
Dec 8, 2025
Contributor
jsha
left a comment
jsha
left a comment
There was a problem hiding this comment.
Nice catch, thanks for fixing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 978877a35 ("Store authzIDs directly in order table"), the modelToOrder function was updated to decode the new Authzs protobuf column, but the decoded values were never assigned to the order's V2Authorizations field. This caused the StoreAuthzsInOrders feature to not work correctly for reads.
The bug meant that even with StoreAuthzsInOrders enabled:
The fix assigns the decoded authz IDs to V2Authorizations, allowing orders with the new column populated to skip the fallback query.
Also adds TestModelToOrderAuthzs to verify the fix and prevent regression.