Skip to content

Conversation

@incherre
Copy link
Contributor

@incherre incherre commented Mar 7, 2025

Please describe the purpose of this pull request.
Is it to add a new feature? Is it to fix a bug?

How to test
I added a unit test, this test should pass with my change and fail without it.

Have you tested this PR?
No, many of the tests failed before I made any changes on not having an OpenAI API key.

Related issues or PRs
No.

Is your PR over 500 lines of code?
No.

Additional context
This is to fix the scenario where the agent tells you something, and then later can't remember it. For example:
U: "Tell me a joke."
A: "Two parrots are sitting on a perch, one says to the other 'do you smell fish'?"
...
U: "What was that joke you told me weeks ago about fish?"
A: "I'm sorry, I couldn't find any results for 'fish' in my message history"

@cpacker cpacker requested a review from mattzh72 March 28, 2025 06:02
@cpacker cpacker merged commit 6d383c3 into letta-ai:main Mar 28, 2025
@github-project-automation github-project-automation bot moved this from To triage to Done in 🐛 Letta issue tracker Mar 28, 2025
carenthomas pushed a commit that referenced this pull request Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants