Fix: Pass gerrit-project in compose-maven-verify #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checkout-gerrit-change-action requires the gerrit-project input to be passed but it was not. For some reason GitHub Actions is not failing the workflow when it gets to the checkout step. Signed-off-by: Andrew Grimberg <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a missing required input parameter for the checkout-gerrit-change-action in the compose-maven-verify workflow. The action requires the gerrit-project input to function properly, but it was not being passed from the workflow inputs.
- Adds the missing
gerrit-projectinput parameter to the checkout-gerrit-change-action step
askb
reviewed
Jul 31, 2025
askb
approved these changes
Jul 31, 2025
askb
approved these changes
Jul 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checkout-gerrit-change-action requires the gerrit-project input to
be passed but it was not. For some reason GitHub Actions is not failing
the workflow when it gets to the checkout step.
Signed-off-by: Andrew Grimberg [email protected]