Fix: Remove outdated cryptography version pin from RTD workflows #427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove 'cryptography<3.4' constraint from rtdv3 workflows to fix lftools failures caused by incompatibility between old cryptography versions and system pyOpenSSL packages. The outdated pin (cryptography 3.3.2 from 2021) causes TypeError when lftools attempts to use OpenSSL functionality: TypeError: deprecated() got unexpected keyword argument 'name' By removing the constraint, pip will resolve compatible versions of cryptography and its dependencies (including pyOpenSSL) that work together correctly on modern Ubuntu runners (24.04/Python 3.12). This fix allows the 'Running rtdv3' step to complete successfully while maintaining compatibility with lftools and other dependencies. Changes: - gerrit-compose-required-rtdv3-verify.yaml: Remove cryptography pin - gerrit-compose-required-rtdv3-merge.yaml: Remove cryptography pin Signed-off-by: Anil Belur <[email protected]>
askb
force-pushed
the
fix-rtdv3-cryptography-pin
branch
from
a7b0eaf to
33dc379
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes RTD workflow failures by removing an outdated cryptography version pin that was causing compatibility issues with modern Ubuntu runners.
- Remove
cryptography<3.4constraint from pip install commands - Allow pip to automatically resolve compatible cryptography versions
- Fix TypeError in lftools commands caused by version incompatibility
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/gerrit-compose-required-rtdv3-verify.yaml | Remove cryptography version pin from pip install command |
| .github/workflows/gerrit-compose-required-rtdv3-merge.yaml | Remove cryptography version pin from pip install command |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
eb-oss
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The RTD validation workflows fail when running lftools commands with:
Root Cause
The workflows install
cryptography<3.4(version 3.3.2 from 2021), which is incompatible with the system-installed pyOpenSSL package on modern Ubuntu runners (24.04/Python 3.12).Solution
Remove the outdated
cryptography<3.4constraint and let pip resolve compatible versions automatically.Changes:
Why this approach?
Option 1 (Implemented): Remove the pin entirely
Option 3 (Not chosen): Add pyOpenSSL upgrade
Impact
Testing
Environment
Fixes the lftools/RTD deployment step failures in projects using these reusable workflows.
Signed-off-by: Anil Belur [email protected]