Add revert functionality #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhchavez
approved these changes
Jan 6, 2019
lhchavez
reviewed
Jan 6, 2019
carlosmn
reviewed
Jan 15, 2019
revert.go
Outdated
|
|
||
| // RevertOptions contains options for performing a revert | ||
| type RevertOptions struct { | ||
| Version uint |
There was a problem hiding this comment.
Version is not a user setting but decided at compile time to let libgit2 know what idea of the struct these bindings know about. It should always be set to C.GIT_REVERT_OPTIONS_VERSION. You use this for the default, but override for the case where someone passes in something. You should also prefer to use the function to initialize the default (though right now in this case it is admitedly not a complex default).
There was a problem hiding this comment.
Thanks for the feedback. Version has been removed from RevertOptions. The value of version in the C struct is now always set to C.GIT_REVERT_OPTIONS_VERSION.
Version is defaulted to GIT_REVERT_OPTIONS_VERSION
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #436