-
Notifications
You must be signed in to change notification settings - Fork 67
Support cross-building for 32-bit arm #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I guess you could try to use the Debian 9 build for the linux-arm RID, and that file would be used for Debian 9, Ubuntu 18.04 and Ubuntu 18.10. They should all satisfy the declared dependencies. |
Looking at the current RID graph, I'm currently thinking that providing a However, before doing that, we should verify that the debian 9 binary would actually work properly on Ubuntu. |
I have ARM hardware so I can run some tests. Ideally I'd run them in a CI system (e.g. Drone CI) so they outcome is documented and reproducible. How do you want to test this? Is there a test suite from libgit2sharp I can run with the ARM binaries that should pass? |
Yes, running the LibGit2Sharp tests would be perfect. The primary thing I want to test before we merge this PR would be that if we shipped The easiest way to accomplish that might be to build a pre-release version of the nativebinaries package and then reference that from LibGit2Sharp. |
@qmfrederik Let's make the same changes here as we did for the ARM64 PR. |
@bording Sure, I updated the PR and squashed the commits. I'll monitor CI; let me know if there's anything else you need from me. Thanks for your patience! |
@bording Gentle ping, do you think this PR is ready to be merged? |
@qmfrederik After an extreme delay, it looks like some progress is finally being made again, so I've incorporated the changes here into #96. The goal is to be able to provide a single binary per architecture now that it seems achievable to remove OpenSSL as a requirement, so I'm moved to just using the debian-based image for arm/arm64, We'll have to see if that works, and if not tweak things as we go. |
#96 is merged, so this is in master now. |
Thanks @bording. Here's to cross-platform, cross-distro libgit2 on Linux! |
As a follow-up to #91, this adds support for cross-building for 32-bit arm.
.NET Core 2.1, 2.2 and 3.0 support/will support 32-bit arm on Ubuntu 16.04, Ubuntu 18.04, Ubuntu 18.10 and Debian 9:
This keeps the RID graph rather limited, so this PR includes cross-builds for all these distros individually.
As for the dependencies, Ubuntu 18.04 and Ubuntu 18.10 end up with the same dependencies. Debian 9 has very similar dependencies, with the difference of
ld-lnux-armhf.so.3
not being required: