Skip to content

Get a CoreCLR build bot. #1019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Therzok opened this issue Apr 10, 2015 · 9 comments
Closed

Get a CoreCLR build bot. #1019

Therzok opened this issue Apr 10, 2015 · 9 comments

Comments

@Therzok
Copy link
Member

Therzok commented Apr 10, 2015

I think we should also test this as a target.

@carlosmn
Copy link
Member

Do we know of a hoster that does this? Does someone have Debian packages we can install?

@Therzok
Copy link
Member Author

Therzok commented Apr 10, 2015

I'm going to time the time it takes to build coreclr itself and mess with it a bit.

@Therzok
Copy link
Member Author

Therzok commented Apr 10, 2015

We'd still need assemblies from corefx. Hmmm, this is going to be tricky.

@Therzok
Copy link
Member Author

Therzok commented Apr 10, 2015

It took 10 mins more or less to build coreclr from source. But we need some place to get the assemblies libgit2sharp uses. Any ideas? We could make a nuget package with the corefx assemblies we and our dependencies use.

@bording
Copy link
Member

bording commented May 16, 2015

Why would we need to build CoreCLR from source? Couldn't we just use dnvm to grab everything we need?

https://github.com/dotnet/coreclr/blob/master/Documentation/get-dotnetcore-dnx-linux.md
https://github.com/dotnet/coreclr/blob/master/Documentation/get-dotnetcore-dnx-osx.md
https://github.com/dotnet/coreclr/blob/master/Documentation/get-dotnetcore-dnx-windows.md

On the windows side, AppVeyor already has Visual Studio 2015 RC, so we'd probably be able to skip some steps there.

xUnit already has a dnx test runner too:
https://github.com/xunit/dnx.xunit

@bording
Copy link
Member

bording commented May 18, 2015

I spent some time this weekend digging into the dnx/coreCLR stuff, and started trying to get things up with the new dnx project system, etc. There are some pretty cool things the new project.json format enables, like easily targeting multiple frameworks simultaneously, but there are also a few things it doesn't support. For example, none of the stuff that gets done via msbuild targets currently will work in the new system.

In general, it looks like running on coreCLR is going to be tough at the moment. It looks like there is a decent amount of stuff that isn't in there (yet?), including a lot of marshaling stuff.

Take a look at the bording/dnx branch to see what I've got so far.

@bording
Copy link
Member

bording commented May 27, 2015

Looking through the dotnet/corefx repo, I found several open issues related to things that LibGit2Sharp uses that aren't currently supported on CoreCLR:

dotnet/corefx#1345
dotnet/corefx#1346
dotnet/corefx#1347

@Kukkimonsuta
Copy link

There is really just one blocking issue and that's missing ICustomMarshaller. There was no reaction yet on whether it will be added or not.

Binary serialization seem to be only used for exceptions in LibGit2Sharp to conform to standards, so just not implementing it when targeting CoreCLR should work just fine.

As for CERs, there's likely no need for them (see reply in dotnet/corefx#1345).

There are few other things that are missing in CoreCLR, like getting home folder and environment variables, but it's been a while since I played with it, so they may have been added or there may be other way to get them.

@AArnott
Copy link
Contributor

AArnott commented Mar 29, 2016

BTW, supporting CoreCLR is a very different thing than building on it or using DNX. I see remarks above about project.json and losing MSBuild. These things are not necessary. You can target CoreCLR, build with MSBuild, and run on desktop, Mac, and Linux within a project that is any of these.

@Therzok Therzok closed this as completed Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants