Skip to content

Support --patience flag of diff-tree command #1037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dmalikov opened this issue Apr 30, 2015 · 5 comments
Closed

Support --patience flag of diff-tree command #1037

dmalikov opened this issue Apr 30, 2015 · 5 comments

Comments

@dmalikov
Copy link
Contributor

Currently Diff.Compare<Patch> method doesn't support --patience flag, thus it's impossible to implement git command like that using the library:

git diff-tree T1 T2 --patience
@Therzok
Copy link
Member

Therzok commented Apr 30, 2015

The flags are binded here.

I guess it's just a matter of exposing this data in CompareOptions

@nulltoken
Copy link
Member

I guess it's just a matter of exposing this data in CompareOptions

Indeed!

Labeled as up-for grabs.

@dmalikov
Copy link
Contributor Author

dmalikov commented May 4, 2015

@nulltoken could you please explain a little bit what does "up-for-grabs" label actually mean?

@bording
Copy link
Member

bording commented May 4, 2015

@dmalikov The idea behind that label comes from here:

http://up-for-grabs.net/

@nulltoken
Copy link
Member

@dmalikov This means that we would be interested in exposing this feature but, as it doesn't require a strong expertise to make it happen, core contributors will refrain from implementing it.

Indeed, it may be an easy first task for a new contributor willing to dabble with the library and we would happily support him/her until the feature's ready to be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants