-
Notifications
You must be signed in to change notification settings - Fork 899
Leaks configuration #869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See SafeHandleBase. A warning is issued when we forgot to explicitly release a handle. The configuration allows to activate the StackTrace and find out where the handle was initially "allocated". |
Well, can't we just define a LEAKS symbol in Debug/Release whenever we want to? I see no need for an extra configuration. |
👍 Would you fancy a PR? 😉 |
Sir, will do, sir! |
Here's the deal: I'll make a PR which fixes 3 issues or 3 PRs which fix these issues in the following order:
|
I think having 3 separated PRs would be easier. Some would be easier to merge/less subject to debate than others. Also, one PRs may turn into a hell of fixups for you. I'd go with 3. Feel free to transmute the issues into PRs. I tend to do this though http://issue2pr.herokuapp.com/. |
Any reason for having this?
The text was updated successfully, but these errors were encountered: