Skip to content

Fail gracefully when tree commit create fails #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion LibGit2Sharp/TreeDefinition.cs
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,12 @@ internal Tree Build(Repository repository)
builtTreeEntryDefinitions.ForEach(t => entries[t.Item1] = t.Item2);

ObjectId treeId = builder.Write();
return repository.Lookup<Tree>(treeId);
var result = repository.Lookup<Tree>(treeId);
if (result == null)
{
throw new LibGit2SharpException("Unable to read created tree");
}
return result;
}
}

Expand Down