-
Notifications
You must be signed in to change notification settings - Fork 899
Remove manual connection to remote #1038
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc @nulltoken |
This resulted in double dialog asking for credentials on MonoDevelop, and I traced it back here. |
The connect called from inside |
Explanation: Before, it was not attemping a remote connection if you were connected already to the remote. Now, it always attempts a connection. |
This fixes the issue I was having though, so I'm pretty sure it's getting double connection in libgit2 land. I'm getting the credential callback twice, once from git_remote_connect, once from git_remote_push. |
That would mean that |
Opened an issue on libgit2 side. :P Until then, this works for me. |
@nulltoken it's not used only there.
Also, libgit2/libgit2#3096 for reference. |
@Therzok Sorry. It was a typo. I meant |
4fa581f
to
9ddca31
Compare
Done. |
Remove manual connection to remote
👍 🍌 |
Published as NuGet pre-release package |
As seen in https://github.com/libgit2/libgit2/blob/master/src/remote.c#L2381-L2397