All unit tests fail because of Mono.Unix.UnixPath in BuildPath #1040

nulltoken · 2015-05-14T17:03:10Z

I just rebased my fork with latest from the vNext branch and hit an issue, which seems to be directly related to PR #1018 - all unit tests fail with the following exception:

System.TypeInitializationExceptionThe type initializer for 'LibGit2Sharp.Tests.TestHelpers.BaseFixture' threw an exception.
   at LibGit2Sharp.Tests.TestHelpers.BaseFixture..ctor()
   at LibGit2Sharp.Tests.CheckoutFixture..ctor()
System.TypeInitializationExceptionThe type initializer for 'LibGit2Sharp.Tests.TestHelpers.Constants' threw an exception.
   at LibGit2Sharp.Tests.TestHelpers.BaseFixture.IsFileSystemCaseSensitiveInternal() in BaseFixture.cs: line 94
   at LibGit2Sharp.Tests.TestHelpers.BaseFixture.SetUpTestEnvironment() in BaseFixture.cs: line 57
   at LibGit2Sharp.Tests.TestHelpers.BaseFixture..cctor() in BaseFixture.cs: line 29
System.Reflection.TargetInvocationExceptionException has been thrown by the target of an invocation.
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Object[] arguments, Signature sig, Boolean constructor)
   at System.Reflection.RuntimeMethodInfo.UnsafeInvokeInternal(Object obj, Object[] parameters, Object[] arguments)
   at System.Reflection.RuntimeMethodInfo.Invoke(Object obj, BindingFlags invokeAttr, Binder binder, Object[] parameters, CultureInfo culture)
   at System.RuntimeType.InvokeMember(String name, BindingFlags bindingFlags, Binder binder, Object target, Object[] providedArgs, ParameterModifier[] modifiers, CultureInfo culture, String[] namedParams)
   at System.Type.InvokeMember(String name, BindingFlags invokeAttr, Binder binder, Object target, Object[] args)
   at LibGit2Sharp.Tests.TestHelpers.Constants.BuildPath() in Constants.cs: line 46
   at LibGit2Sharp.Tests.TestHelpers.Constants..cctor() in Constants.cs: line 9
System.BadImageFormatExceptionAn attempt was made to load a program with an incorrect format. (Exception from HRESULT: 0x8007000B)
   at Mono.Unix.Native.Syscall.readlink(String path, StringBuilder buf, UInt64 bufsiz)
   at Mono.Unix.UnixPath.ReadSymbolicLink(String path)
   at Mono.Unix.UnixPath.GetRealPath(String path)
   at Mono.Unix.UnixPath.GetCompleteRealPath(String path)

I'm running on Windows 8.1 and VS2013 and the var unixPath = Type.GetType("Mono.Unix.UnixPath, Mono.Posix, Version=2.0.0.0, Culture=neutral, PublicKeyToken=0738eb9f132ed756"); (found here) type is actually not null even though I'm not running *nix. I actually don't know what added Mono.Unix.UnixPath to my GAC, but its obviously causing problems.

It was mentioned in #1018 that Mono.Runtime was used elsewhere to check if "We're running on top of .Net", and changing the type actually makes the unit tests runnable again.

carlosmn · 2015-05-06T09:12:28Z

This isn't about checking whether we're on Mono, it's about figuring out the actual path to the temporary directory on OS X. We would have to do the same under CoreCLR. Having Mono.Posix on Windows is quite odd. It'd be unfortunate if we weren't able to reliably detect whether we can use it.

sitereactor · 2015-05-06T09:29:10Z

I tried to track down where it comes from, and as far as I can tell its from GtkSharp (C:\Program Files (x86)\GtkSharp\2.12\lib\Mono.Posix\Mono.Posix.dll file version 2.0), and its installed with Xamarin, Inc. as the Publisher (installed as Gtk# for .Net 2.12.20).

After uninstalling this everything runs fine again. I'm assuming this is something that is left behind from having Xamarin installed for Visual Studio.

Therzok · 2015-05-06T13:11:45Z

Ah, yes, Xamarin Studio puts some assemblies in the GAC. Sadly, I haven't had time to look at working around it and nuget-ing the assemblies.

carlosmn · 2015-05-06T13:29:43Z

That's very unfortunate. We will have to add a check for the OS as well before we try to use Mono.Posix in that case.

nulltoken · 2015-05-06T14:34:14Z

@sitereactor Nice catch!

IIRC, BaseFixture.cs exposes a helper function IsRunningOnUnix().

Could you check if combining this test would solve the issue?

damageboy · 2015-05-12T04:54:43Z

In my other xplat projects, I also have to use Mono.Posix only when in Mono/Unix (depends on the use case).

The way I always do it is that I put the Mono.Posix dependent functionality in a separate function and the Windows functionality in yet a separate function, something like this:

void public DoSomething()
{
  if (RuntimeSupport.IsRunningOnUnix())
    DoSomethingMono();
  else
    DoSomethingOnWindows();
}

The only calls into Mono.Posix are coming in from DoSomethingMono() which never gets called EVEN A SINGLE TIME when running on Windows and vice-versa.

This, in turn means that the DoSomethingMono() function never gets JIT'd and you can deploy this on a windows machine, where Mono.Posix doesn't even have to exist(!) and everything will work just fine..

When on Linux/Mac, Mono.Posix is part of the "package", e.g. part of Mono, and there's never a chance of not finding it or calling into the wrong (too old one) that you packaged yourself...

Fix #1040

nulltoken · 2015-05-14T17:05:18Z

@damageboy I've pushed something along your proposal.

/cc @jamill I've tried to load the type in a slightly different way in order to not be tied to a specific version of the assembly.

nulltoken · 2015-05-14T18:04:57Z

Grmpf. Something went wrong

Travis Mac OS X build log states

Test working directory set to '/var/folders/gw/_2jq29095y7b__wtby9dg_5h0000gn/T/LibGit2Sharp-TestRepos'

This should rather be private/var/...

Could a good soul running on this platform could take a look at and find out where I messed up, please?

bording · 2015-05-14T18:19:13Z

Pretty sure that path is where mono puts Shadow Copy stuff.

Try adding ShadowCopy="false" to CI/build.msbuild like I did in #984 and see what happens then.

nulltoken · 2015-05-14T19:09:09Z

@bording Build in progress...

nulltoken · 2015-05-14T19:17:12Z

@bording Didn't help. Still getting

/Users/travis/build/libgit2/libgit2sharp/LibGit2Sharp.Tests/bin/Release/LibGit2Sharp.Tests.dll Information : 0 : Test working directory set to '/var/folders/gw/_2jq29095y7b__wtby9dg_5h0000gn/T/LibGit2Sharp-TestRepos'

bording · 2015-05-14T19:29:27Z

😦 Sorry, thought that might be the solution. I'll try and take a look at this tonight then to see what's going on.

bording · 2015-05-15T00:40:21Z

Aha, the problem is with the IsRunningOnUnix check, that is returning false, so the windows code path is being taken.

I noticed that the Using default test path value message was showing up in the build log when it shouldn't be, and I added an extra Trace call to print out a message in the unix path.

It's not showing up.

bording · 2015-05-15T00:46:16Z

And, I think I know why. Both TemporaryReposPath and IsRunningOnUnix are being set with a field initializer, and BuildPath() is being called before the value of IsRunningOnUnix has been set, so it's always false.

About to push a change to confirm.

bording · 2015-05-15T01:00:41Z

Ok, so that did fix the problem with it never calling UnwrapUnixTempPath() and only failing on OS X.

Now it's failing on both of them because it doesn't like how you're trying to load the Mono.Posix assembly:

System.TypeInitializationException : An exception was thrown by the type initializer for LibGit2Sharp.Tests.TestHelpers.BaseFixture

---- System.TypeInitializationException : An exception was thrown by the type initializer for LibGit2Sharp.Tests.TestHelpers.Constants

-------- System.IO.FileNotFoundException : Could not load file or assembly 'Mono.Posix' or one of its dependencies. The system cannot find the file specified.

bording · 2015-05-15T01:18:10Z

Assembly.Load() requires the full name of the assembly, so just using Mono.Posix isn't going to work.

bording · 2015-05-15T01:35:43Z

And there we go, green all around! 🎉

Fix #1040

nulltoken · 2015-05-23T12:18:40Z

@bording Thanks for the help!

Just removed some code duplication on top of it.

Good to go?

bording · 2015-05-23T20:19:48Z

👍

All unit tests fail because of Mono.Unix.UnixPath in BuildPath

nulltoken · 2015-05-23T20:30:37Z

@sitereactor Nice report, Sir! Thanks a lot for this ✨
@damageboy Your idea made it into a fix! 👍
@bording 😍

nulltoken · 2015-05-27T18:11:45Z

Published as NuGet pre-release package LibGit2Sharp.0.22.0-pre20150527180327

nulltoken added a commit that referenced this pull request May 14, 2015

Refactor unwrapping of temp repository on unix

9f7e134

Fix #1040

nulltoken force-pushed the ntk/issue_1040 branch from 087c9c5 to 2bd16e4 Compare May 23, 2015 10:59

bording added a commit that referenced this pull request May 23, 2015

Refactor unwrapping of temp repository on unix

2bd16e4

Fix #1040

nulltoken force-pushed the ntk/issue_1040 branch from 2bd16e4 to 7a5481b Compare May 23, 2015 11:51

bording added a commit that referenced this pull request May 23, 2015

Refactor unwrapping of temp repository on unix

7a5481b

Fix #1040

Refactor unwrapping of temp repository on unix

130d7bc

Fix #1040

nulltoken force-pushed the ntk/issue_1040 branch from 7a5481b to 130d7bc Compare May 23, 2015 11:56

nulltoken added a commit that referenced this pull request May 23, 2015

Merge pull request #1040 from libgit2/ntk/issue_1040

645d89e

All unit tests fail because of Mono.Unix.UnixPath in BuildPath

nulltoken merged commit 645d89e into vNext May 23, 2015

nulltoken deleted the ntk/issue_1040 branch May 23, 2015 20:28

nulltoken added this to the v0.22 milestone May 23, 2015

nulltoken added the nuget-pre label May 27, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

All unit tests fail because of Mono.Unix.UnixPath in BuildPath #1040

All unit tests fail because of Mono.Unix.UnixPath in BuildPath #1040

nulltoken commented May 14, 2015

carlosmn commented May 6, 2015

sitereactor commented May 6, 2015

Therzok commented May 6, 2015

carlosmn commented May 6, 2015

nulltoken commented May 6, 2015

damageboy commented May 12, 2015

nulltoken commented May 14, 2015

nulltoken commented May 14, 2015

bording commented May 14, 2015

nulltoken commented May 14, 2015

nulltoken commented May 14, 2015

bording commented May 14, 2015

bording commented May 15, 2015

bording commented May 15, 2015

bording commented May 15, 2015

bording commented May 15, 2015

bording commented May 15, 2015

nulltoken commented May 23, 2015

bording commented May 23, 2015

nulltoken commented May 23, 2015

nulltoken commented May 27, 2015

All unit tests fail because of Mono.Unix.UnixPath in BuildPath #1040

All unit tests fail because of Mono.Unix.UnixPath in BuildPath #1040

Conversation

nulltoken commented May 14, 2015

carlosmn commented May 6, 2015

sitereactor commented May 6, 2015

Therzok commented May 6, 2015

carlosmn commented May 6, 2015

nulltoken commented May 6, 2015

damageboy commented May 12, 2015

nulltoken commented May 14, 2015

nulltoken commented May 14, 2015

bording commented May 14, 2015

nulltoken commented May 14, 2015

nulltoken commented May 14, 2015

bording commented May 14, 2015

bording commented May 15, 2015

bording commented May 15, 2015

bording commented May 15, 2015

bording commented May 15, 2015

bording commented May 15, 2015

nulltoken commented May 23, 2015

bording commented May 23, 2015

nulltoken commented May 23, 2015

nulltoken commented May 27, 2015