Bump CustomBuildTasks to .NET 4.0 #1133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bindings are already here, and this also allows us to build both on mono 3 as well as mono 4, which dropped pre-4.0 assemblies from the install.
|
@bording Thoughts? |
| <FileAlignment>512</FileAlignment> | ||
| <TargetFrameworkProfile /> | ||
| <ProductVersion>8.0.30703</ProductVersion> | ||
| <SchemaVersion>2.0</SchemaVersion> |
There was a problem hiding this comment.
With these two lines, and and the missing TargetFrameworkVersion property, this feels like the csproj was created with an older version of VS.
I'd recommend dumping these two lines and adding the <TargetFrameworkVersion>v4.0</TargetFrameworkVersion> line instead.
|
I did the exact same thing last night, but saw it was done in the xunit20 branch already, so I didn't push it up as a PR! #1034 was done before I added Other than the tweak to the csproj I mentioned above, LGTM. |
|
I think this has been iterated like 4 times now. 🍡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bindings are already here, and this also allows us to build both on
mono 3 as well as mono 4, which dropped pre-4.0 assemblies from the
install.
This is just #1034 but this is in a branch which I can push to :)