-
Notifications
You must be signed in to change notification settings - Fork 899
Restrict potential reference targets of HistoryRewriter #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It feels odd that we would have a whitelist or blacklist about rewriting, since it's inherently an operation in which you do whatever you want to the data. |
So that would be a 👎 with regards to preventing the rewrite of What about notes? We can't actually rewrite them due to their internal format IIRC. |
It makes sense to me if we can't do anything meaningful that we throw... But I agree that rewriting |
Hmmm. Actually, the So two options there:
Thoughts? |
I'm going to go with this option for now, push up something so we can discuss further about it |
Ready for review |
f39a648
to
59eb6c8
Compare
Restrict potential reference targets of HistoryRewriter
Published as NuGet pre-release package |
Currently, the
HistoryRewriter
will blindy rewrite any reference that's being passed to it.However, this may make no sense to rewrite the remote tracking branches.
Moreover, the way git notes are structured isn't actually handled by the rewriting process.
Proposal:
ref/notes/
be passed, throw a NotSupportedException with a meaningful message.ref/remotes/
Thoughts?