fix bug of not sending full messages to peers that requested partial #657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukunrt
approved these changes
Dec 9, 2025
Member
sukunrt
left a comment
sukunrt
left a comment
There was a problem hiding this comment.
I think the approach suggested in the comment would make this cleaner. But this looks correct :)
gossipsub.go
Outdated
Comment on lines
1401
to
1402
| func (gs *GossipSubRouter) sendPeerPartialMessage(p peer.ID, topic string) bool { | ||
| myTopicState := gs.p.myTopics[topic] |
Member
There was a problem hiding this comment.
I'd suggest structuring this as 4 methods.
- PeerSupportsReceivingPartial(p, topic)
- PeerSupportsSendingPartial(p, topic)
- ICanReceivePartial(topic)
- ICanSendPartial(topic)
When we support partial extensions.
MarcoPolo
force-pushed
the
pm-bug-wrong-omit
branch
from
c82dccb to
1f3087a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we support partial extensions.