Skip to content
This repository was archived by the owner on Jul 21, 2023. It is now read-only.
This repository was archived by the owner on Jul 21, 2023. It is now read-only.

navigator.userAgent is unreliable in determining if the browser is webkit on linux #318

Closed
@MarcoPolo

Description

@MarcoPolo

Seeing failure in CI and locally on a linux box that should have been fixed by #313. The problem is that the user agent reported is "Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/16.4 Safari/605.1.15", which doesn't let us know if this is linux or mac.

Seeing this issue on adding webkit to js-libp2p libp2p/js-libp2p#1627 on this run.

Not sure why the CI here isn't hitting it. Maybe the browser was updated? I'll run the CI again to check.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions