feat: add timeout defaults #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jacob Heun <[email protected]>
ghost
assigned
vasco-santos
suggested changes
Sep 26, 2018
src/index.js
Outdated
| @@ -25,15 +26,25 @@ class DelegatedPeerRouting { | |||
| * Attempts to find the given peer | |||
| * | |||
| * @param {PeerID} id | |||
| * @param {number} timeout How long the query can take. Defaults to 30 seconds | |||
There was a problem hiding this comment.
Since we are changing this, maybe we should change this param to an options object with the timeout property, and for now, keep accepting it as a number, but deprecate in the future, in favor of options.
There was a problem hiding this comment.
Yeah, that sounds good, let's change those up!
License: MIT Signed-off-by: Jacob Heun <[email protected]>
|
Updated the timeout change to match the kad dht changes libp2p/js-libp2p-kad-dht#45 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR aims to mitigate an issue where connections to the delegate node would stay open for an extended period. This change will pass the
timeoutparam to the API allowing for better limiting.findPeer, which is compatible with the kad dht. This also sets a default limit of 30 seconds to limit the http calls to the delegate.Reference: ipfs/kubo#4595 (comment)
I have verified this using the WIP libp2p implementation and a local go-ipfs delegate node.