Skip to content
This repository was archived by the owner on Feb 24, 2021. It is now read-only.

fix: remove use of assert module#114

Merged
jacobheun merged 1 commit into
masterfrom
remove-use-of-assert
Feb 13, 2020
Merged

fix: remove use of assert module#114
jacobheun merged 1 commit into
masterfrom
remove-use-of-assert

Conversation

@achingbrain
Copy link
Copy Markdown
Member

The polyfill is big, we can simulate it by throwing an Error and it doesn't work under React Native.

The polyfill is big, we can simulate it by throwing an Error and it doesn't work under React Native.
Copy link
Copy Markdown
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacobheun jacobheun merged commit 027e0ad into master Feb 13, 2020
@jacobheun jacobheun deleted the remove-use-of-assert branch February 13, 2020 16:50
mikevoronov added a commit to fluencelabs/js-libp2p-secio that referenced this pull request Feb 23, 2020
* chore: update deps (libp2p#113)

* chore: update contributors

* chore: release version v0.12.2

* fix: remove use of assert module (libp2p#114)

The polyfill is big, we can simulate it by throwing an Error and it doesn't work under React Native.

* chore: update contributors

* chore: release version v0.12.3

* chore(deps-dev): bump aegir from 20.6.1 to 21.0.2 (libp2p#117)

Bumps [aegir](https://github.com/ipfs/aegir) from 20.6.1 to 21.0.2.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v20.6.1...v21.0.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>

Co-authored-by: Jacob Heun <jacobheun@gmail.com>
Co-authored-by: Alex Potsides <alex@achingbrain.net>
Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants