Fix: Add util helper function to resolve ring topography ci checks failure #1168
+110
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #1164
How was it fixed?
What I changed in your original function #1164 (comment)
In
wait_for_convergence():Added tracking of the last exception
check(node)raises, we store the exception and node index.raise_last_exception_on_timeout(default True)On timeout, if we saw an exception during checks, we now raise:
AssertionError("Convergence failed (node index X): ") from
This keeps the real assertion failure visible (and chained), instead of masking it behind TimeoutError.