fix: Added timeout paramter into muxer multistream #896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@unniznd : This looks great. Please add the newsfragment file. Will ask @sumanjeet0012 to review it once. Looking forward to do a final review + merge in a day or so. |
|
@seetadev it already have a newsfragment. |
|
@unniznd : Great, just noticed it. Sorry, missed it earlier. Reviewing the PR. |
|
@unniznd : This looks great to merge. Thank you so much for your efforts. Appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
The timeout infrastructure is already implemented in the underlying components, but the
MuxerMultistreamclass doesn't expose this configuration.How was it fixed?
Exposed the timeout and updated the usage. Added testcases to verify the same