Repository navigation
chore(toolchain): pin Bun 1.4.4 - #2035
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced Oct 28, 2026
Bun 1.4.2 on Windows segfaults when bun:test's expect(promise).rejects runs a nested event loop inside a socket dispatch (oven-sh/bun#39643, relanded in 1.4.4 by oven-sh/bun#42667). #2029 worked around it in one test file; moving the pin removes the cause for every file. The packageManager pin, every setup-bun bun-version and npm install of bun in the workflows, the three Dockerfile deps stages, the dev container and the contributor docs move together. Notes that record a measurement taken on 1.4.2 keep that version.
The seed one-shot runs on the repository's own Bun, so its image follows the packageManager pin. The digest is the oven/bun:1.4.4 index digest from Docker Hub.
…est destroys the socket A TLS client destroyed in the same tick as its secureConnect resets the connection before the server reads the client's Finished, so the server never completes its side. Node does that, and Bun does from 1.4.4, so the test waits for the server's side of each handshake.
…un 1.4.4 Bun 1.4.2 threw until the statement had run; 1.4.4 answers before and after with the same answer. The bridge still reads it after the rows, so an older Bun keeps working. The provider doc records the re-measure on the new pin.
… under Bun 1.4.4 too Bun 1.4.4 emits the TLS layer's code before the reset, as Node does, so the Node-only expectation becomes the expectation for both runtimes.
Bun 1.4.4's fetch reports a refused port as ECONNREFUSED, where 1.4.2 said ConnectionRefused, and no longer quotes a refused header value in its message. The transport already read both codes and never copied the message, so only the controls and the wording change.
From Bun 1.4.4 grpc-js carries the server's alert as TLSV1_ALERT_CERTIFICATE_REQUIRED or TLSV1_ALERT_UNKNOWN_CA, where 1.4.2 said only Failed to connect. The TLS cause table matched OpenSSL's spelling only, so under Bun the refusal read as a failure with no cause named, beside the cause itself.
Bun 1.4.4 reports the TLS proxy's alert through grpc-js in BoringSSL's capitals; the classifier now reads them as Node's, so a missing or untrusted client certificate gets its own sentence under Bun too.
Bun 1.4.4 reports the server's alert through grpc-js in BoringSSL's capitals; the TLS cause table now reads them as Node's.
The same TLS cause table as etcd and Milvus, for the same Bun 1.4.4 texts.
…y declaredTypes read The Spark error table, and the etcd and Milvus runtime flag comments, still said Bun reports no TLS alert; from 1.4.4 it does, and the flag only words a TLS failure that names no cause. A stand-in bun statement that refuses declaredTypes until it has run now keeps the bun adapter reading it after the rows, as a Bun before 1.4.4 needs.
cevheri
force-pushed
the
chore/bun-1.4.4
branch
from
October 28, 2026 20:25
061d40e to
80670c4
Compare
cevheri
marked this pull request as ready for review
October 28, 2026 20:25
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Pins Bun 1.4.4 everywhere it was pinned at 1.4.2 (packageManager, workflows, Dockerfiles, devcontainer, the RabbitMQ seed image, CONTRIBUTING). 1.4.4 fixes the Windows segfault #2029 worked around in one file (oven-sh/bun#39643).
Tests and classifiers that followed 1.4.2's behaviour now follow 1.4.4's, which matches Node: TLS socket teardown, bun:sqlite
declaredTypes, fetch error codes, and the etcd, Spark, Milvus and Oxia classifiers also naming BoringSSL's TLS alert spelling, so the reason for a client-certificate failure now shows under Bun too.Bun 1.4.2 attributed coverage hits to the wrong lines; the lines it hid are covered by #2038, #2039, #2040 and #2042. On 1.4.4 every gate passes locally, coverage 189483/189483 lines. The debian image builds and answers /api/health.