Skip to content

fix: Fix build failure with passthrough-decoder #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roderickvd merged 1 commit into from
Nov 9, 2025
Merged

fix: Fix build failure with passthrough-decoder #1630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions playback/src/player.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,22 +1119,20 @@ impl PlayerTrackLoader {
})
};

let mut hint = Hint::new();
if let Some(mime_type) = AudioFiles::mime_type(format) {
hint.mime_type(mime_type);
}

#[cfg(feature = "passthrough-decoder")]
let decoder_type = if self.config.passthrough {
PassthroughDecoder::new(audio_file, format).map(|x| Box::new(x) as Decoder)
} else {
symphonia_decoder(audio_file, format)
symphonia_decoder(audio_file, hint)
};

#[cfg(not(feature = "passthrough-decoder"))]
let decoder_type = {
let mut hint = Hint::new();
if let Some(mime_type) = AudioFiles::mime_type(format) {
hint.mime_type(mime_type);
}

symphonia_decoder(audio_file, hint)
};
let decoder_type = { symphonia_decoder(audio_file, hint) };

let normalisation_data = normalisation_data.unwrap_or_else(|| {
warn!("Unable to get normalisation data, continuing with defaults.");
Expand Down