fix: add fallback for vergen git values #1669
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds fallback handling for vergen-gitcl when git information is unavailable (e.g., when the package is used as a dependency without a .git folder), fixing issue #1572 where version constants would contain VERGEN_IDEMPOTENT_OUTPUT.
- Implements error handling for git value generation with sensible fallback defaults
- Refactors build ID generation to use more idiomatic Rust syntax
- Updates changelog to document the fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| core/build.rs | Adds error handling for missing git repo with fallback values ("stable" for SHA, "unknown" for commit date), splits git and build emission into separate operations, and refactors build_id assignment to use unwrap_or_else |
| CHANGELOG.md | Documents the fix for version constants containing VERGEN_IDEMPOTENT_OUTPUT |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds default values for the
vergen-gitclgit values, when no.gitfolder is found for the dependency.Fixes #1572