fix: Corrected discovery retry uptime limit to be 1 minute instead of 1 second #1675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the discovery retry logic where the uptime limit was incorrectly set to 1 second instead of 1 minute. The issue stemmed from /proc/uptime returning seconds since startup, not minutes, leading to a mismatch between the intended behavior (retry for 1 minute) and the actual implementation (retry for 1 second).
- Introduced a new constant
DISCOVERY_RETRY_UPTIME_LIMITset to 60 seconds for clarity - Fixed the uptime comparison logic to properly convert and compare durations
- Updated comments and debug messages to accurately reflect the actual behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/main.rs | Added constant for discovery retry uptime limit, fixed uptime comparison logic, and updated comments/debug messages to reflect correct behavior |
| CHANGELOG.md | Added entry documenting the discovery retry uptime limit fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kingosticks
approved these changes
Jan 7, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/proc/uptime contains seconds since startup, not minutes