Screenshot Notification Persistence option wrongly applies to Save State Slot notification speed, if Save State Thumbnails is ON

[OctopusButtons]

Is there an existing issue for this?

• This is a bug in RetroArch frontend
• I have searched the existing issues

Description

In 1.22.2, the Screenshot Notification Persistence wrongly applies to save state notification persistence when incrementing up/down the current save state slot (slot 1, 2, 3, 4, etc) if Save State Thumbnails is turned On.

So the save state notification is instant, depending on the screenshot speed setting and the Save State Thumbnail setting. (That's a problem because a user needs to be able to easily read the number for a save state slot, unlike a screenshot where the user doesn't need to be able to read any specific screenshot information in the screenshot notification other than the fact that a screenshot notification occurred.)

History / Attempted bisect:

• The problem goes at least as far back as 1.21
• The problem only happens when Save State Thumbnails is turned on, because the save slot notification uses the screenshot persistence code.
• The problem is present in Nightly def16f3 (which is a month old, it's currently taking me forever to download the newer latest nightly)

Expected behavior

Save State slot notification speed/persistence should be normal, or not controlled by Screenshot Notification Persistence setting, regardless of whether Save State Thumbnails is turned on.

Steps to reproduce the bug

1. Turn ON the option for Settings > Saving > Save State Screenshots
2. Set Settings > User Interface > On-screen Notifications > Notification Visibility > Screenshot Notification Persistence to normal or slow
3. Go in-game and Increment your save slot up/down (1,2,3 etc)
4. Observe the duration of the notification that says which slot # is active
5. Now go into Settings > User Interface > On-screen Notifications > Notification Visibility and change Screenshot Notification Persistence to Instant
6. Go in-game and increment your save slot up/down again... the notification persistence for the Slot # will be Instant or fast if the Screenshot Notification Persistence is set to instant or fast and if Save State Screenshots is ON

Version/Commit

1.22.2 (69a4f0e)

Bisect Results

Present in the nightly version

Yes, this is reproduced in the nightly build

Platform & operating system

Windows 11

Affected Cores

No response

Environment information

Video Driver: d3d11

Relevant log output