Fix double close of run loop on MacOS#522
Merged
Youw merged 1 commit intolibusb:masterfrom Apr 9, 2023
Merged
Conversation
sezero
added a commit
to sezero/SDL
that referenced
this pull request
Apr 24, 2023
libusb/hidapi@c1b9d2a Properly handle the close of run loop on macOS (libusb/hidapi#522) - as per documentation `kCFRunLoopRunStopped` should be handled once the runloop is closed via `CFRunLoopStop`; - if it is not handled - a race condition/crash may happen on the latest macOS when a device gets disconnected while being open;
slouken
pushed a commit
to libsdl-org/SDL
that referenced
this pull request
Apr 24, 2023
libusb/hidapi@c1b9d2a Properly handle the close of run loop on macOS (libusb/hidapi#522) - as per documentation `kCFRunLoopRunStopped` should be handled once the runloop is closed via `CFRunLoopStop`; - if it is not handled - a race condition/crash may happen on the latest macOS when a device gets disconnected while being open;
slouken
pushed a commit
to libsdl-org/SDL
that referenced
this pull request
Apr 24, 2023
libusb/hidapi@c1b9d2a Properly handle the close of run loop on macOS (libusb/hidapi#522) - as per documentation `kCFRunLoopRunStopped` should be handled once the runloop is closed via `CFRunLoopStop`; - if it is not handled - a race condition/crash may happen on the latest macOS when a device gets disconnected while being open; (cherry picked from commit 62d1a2c)
sezero
added a commit
to sezero/SDL
that referenced
this pull request
May 17, 2023
libusb/hidapi@c1b9d2a Properly handle the close of run loop on macOS (libusb/hidapi#522) - as per documentation `kCFRunLoopRunStopped` should be handled once the runloop is closed via `CFRunLoopStop`; - if it is not handled - a race condition/crash may happen on the latest macOS when a device gets disconnected while being open; (cherry picked from commit 62d1a2c)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.