Add non-breaking space between number and unit#3449
Open
assassinaj602 wants to merge 3 commits into
Open
Conversation
Replace regular spaces with U+00A0 in number+unit displays to prevent line-break jitter as numbers change width. Fixes lichess-org#2289
Contributor
|
Add non breaking space in red test too |
- Updated test expectations to use \u00A0 between numbers and units - Matches the implementation changes in storm_screen.dart Fixes lichess-org#2289
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace regular spaces with U+00A0 (non-breaking space) between numbers and their unit suffixes to prevent line-break jitter as numbers change width.
Changes
storm_screen.dart— combo level labels (${level} s), run stats time and time-per-move rows, stats section header (${score} puzzles solved)storm_dashboard.dart— daily highscore time column (${time} s)puzzle_history_screen.dart— solving time badge (${inSeconds} s)engine_settings_widget.dart— search time slider label (${value} s)Not changed (intentional)
.arbtranslation files —opponentLeftCounter,nbSecondsToPlayTheFirstMoveetc. embed numbers inside full ICU plural sentences; those are the translation team's responsibilitytoDaysHoursMinutes()— delegates tol10n.nbDays/nbHours/nbMinutespluralsFixes #2289