Skip to content

Conversation

@mrexodia
Copy link
Contributor

@mrexodia mrexodia commented Mar 20, 2021

Copy link
Contributor

@ekilmer ekilmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fixes!

Not sure how I didn't run into this earlier. CMake seems to set WIN32 when compiling on Windows, but I think it's better to use the standard define 👍

https://github.com/Kitware/CMake/blob/6d4cbf7416f8ab4d001ca08ca4e108615ea5dfb1/Modules/Platform/Windows-MSVC.cmake#L224

@ekilmer ekilmer merged commit eec3dee into lifting-bits:master Mar 22, 2021
@mrexodia
Copy link
Contributor Author

mrexodia commented Mar 22, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants