Skip to content

Replace SIGSTKSZ with our own constant #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ekilmer merged 1 commit into from
Jan 10, 2023
Merged

Replace SIGSTKSZ with our own constant #646

ekilmer merged 1 commit into from
Jan 10, 2023

Conversation

@ekilmer
Copy link
Contributor

@ekilmer ekilmer commented Jan 6, 2023 •
edited
Loading

closes #635

@ekilmer ekilmer changed the title Remove trailing whitespace from sleigh patches Various fixes Jan 6, 2023
@ekilmer ekilmer mentioned this pull request Jan 9, 2023
Closed
@ekilmer ekilmer marked this pull request as ready for review January 10, 2023 14:59
@ekilmer ekilmer requested a review from 2over12 January 10, 2023 14:59
@ekilmer ekilmer changed the title Various fixes Patch whitespace fix and SIGSTKSZ replacement Jan 10, 2023
@ekilmer ekilmer changed the title Patch whitespace fix and SIGSTKSZ replacement Replace SIGSTKSZ with our own constant Jan 10, 2023
@ekilmer
Fix SIGSTKSZ no longer being constant in glibc 2.34+
98c170a 
Set our own constant and use that
2over12
2over12 approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@2over12 2over12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ekilmer ekilmer merged commit 66832ff into master Jan 10, 2023
@ekilmer ekilmer deleted the ekilmer/fixes branch January 10, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@pgoodman pgoodman pgoodman approved these changes

@2over12 2over12 2over12 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Tests fail to build on glibc>=2.34 (Ubuntu 22.04)

4 participants

@ekilmer @pgoodman @2over12