llvm 17 fixes #688
Merged
llvm 17 fixes #688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2over12
commented
Oct 4, 2023
| } | ||
| func_manager.doFinalization(); | ||
| module_manager.run(*module); | ||
| OptimizeBareModule(module, guide); |
Contributor
Author
There was a problem hiding this comment.
Not sure what we want to do about this i dont see an easy way to do single function inlining anymore i guess we could probably manually call llvm::InlineFunction etc but that seems excessive for something only called in the trace lifter idk
Ninja3047
approved these changes
Oct 6, 2023
Collaborator
Ninja3047
left a comment
Ninja3047
left a comment
There was a problem hiding this comment.
build stuff looks good
just a question about why the select case is removed
Co-authored-by: William Tan <[email protected]>
This reverts commit 6c727a5.
* Clear space and don't use cxx-common docker image * Run on all PRs * Fix perms * Remove some unnecessary apt commands * Install LLVM version as root * Allow writing to external target * Build before running tests * Install with sudo * Simplify with container volume mounts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.