Skip to content

Catch binary-incompatible method overriding in traits #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2020
Merged

Catch binary-incompatible method overriding in traits #541

merged 1 commit into from
Sep 7, 2020

Conversation

dwijnand
Copy link
Collaborator

@dwijnand dwijnand commented Sep 4, 2020

@dwijnand dwijnand requested a review from lrytz September 4, 2020 16:51
@dwijnand dwijnand force-pushed the forward-bincompat branch 2 times, most recently from 3be42df to 96a05c4 Compare September 4, 2020 20:36
lrytz
lrytz reviewed Sep 7, 2020
View reviewed changes
Copy link
Contributor

@lrytz lrytz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you! The test failures look good, it seems right to update the expected output.

@dwijnand dwijnand modified the milestones: 0.7.1, 0.8.0 Sep 7, 2020
@dwijnand dwijnand merged commit 7c24661 into lightbend-labs:master Sep 7, 2020
@dwijnand dwijnand deleted the forward-bincompat branch September 7, 2020 16:37
@dwijnand dwijnand changed the title Catch forward-incompatible method overriding in traits Catch binary-incompatible method overriding in traits Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lrytz lrytz lrytz left review comments

Assignees
No one assigned
Labels
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@dwijnand @lrytz