Travis fix for jdk11 #230
Merged
Travis fix for jdk11 #230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kpbochenek
force-pushed
the
jdk11
branch
2 times, most recently
from
ace09d4 to
a8dbaeb
Compare
|
Merging this and releasing the new version will help a lot. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup jdk taken from travis docs:
https://docs.travis-ci.com/user/languages/java/#using-java-10-and-late
Similar to(fix openjdk 11): #228
Also contains(mockito-scala 1.5.18): #188
Also contains(scalatest 3.2.0): #222
Also contains(scalatest 3.2.1): #226
Bumping scala 2.13.1 -> 2.13.3 causes jvm panic for oraclejdk11 that's why it is not included here.
2.13.3 works locally okay for me with oraclejdk11, maybe travis uses older version with some kind of bug?
Anyway just worth to mention it somewhere.
Anyone could take a look at this PR? It is mainly maintenance work and maybe groundwork for PR dotty support? Would love to see that merged :D
/cc @sullis
All checks passed 💪