Skip to content

Expose page URL to template #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2017
Merged

Expose page URL to template #110

merged 1 commit into from
May 8, 2017

Conversation

raboof
Copy link
Contributor

@raboof raboof commented May 4, 2017

Might be a first step towards solving #109 more generically

Might be a first step towards solving lightbend#109 more generically
raboof added a commit to akka/akka-http that referenced this pull request May 4, 2017
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good I think :)

@ktoso
Copy link
Contributor

ktoso commented May 8, 2017

@pvlugter can we ask for review and release? We'd like to use this for akka/akka-http#1091 and we're focused on getting docs in shape this sprint :)

Copy link
Member

@pvlugter pvlugter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I haven't been releasing paradox, so adding @eed3si9n and @dwijnand.

@eed3si9n eed3si9n merged commit c60550a into lightbend:master May 8, 2017
@eed3si9n
Copy link
Contributor

eed3si9n commented May 8, 2017

I can get this out now.

@eed3si9n
Copy link
Contributor

eed3si9n commented May 8, 2017

@raboof raboof deleted the selfLink branch May 9, 2017 08:13
@raboof
Copy link
Contributor Author

raboof commented May 9, 2017

Thanks!

raboof added a commit to akka/akka-http that referenced this pull request May 9, 2017
raboof added a commit to akka/akka-http that referenced this pull request May 9, 2017
tomrf1 pushed a commit to tomrf1/akka-http that referenced this pull request Aug 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants