This repository was archived by the owner on May 25, 2023. It is now read-only.
Use go mod with ctr runtime v0.2.0 #4
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with:
Also tested
go mod tidy
required by kubebuilder cmd. WARN: this command will mess the deps.Right now we have master versions k8s.io/* deps but we need to freeze to older ones eg kubernetes-1.14.1 as it is done upstream.
@yuchaoran2011 fyi the new branch is
controller_runtime_0.2.0
and this PR starts with the latest commit upstream.After I merge this I will continue with the webhook stuff and then apply the work you have done.