Add nix flake #68
Open
Add nix flake #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 I see @tankyleo was un-assigned. |
Builds all projects Runs all tests Formats nix files Runs cargo advisory check Updated cargo deps to remove vulnerability Added end to end system test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its great to see a new project to build a server utilising LDK. Nix can help a lot with reproducible/declarative builds and system configuration and testing. I've added a flake to show what it can do.
The flake:
I also updated cargo dependencies to remove a vulnerability found in the advisory check.
And I deleted the
debug_assert!macros in the sqlite store. This is because nix runs the tests on the production optimised build and these were failing as the test expects a panic but doesn't get it. I think its better to keep prod and debug behavior the same in this case.CI now just calls
nix flake check. This means that a developer can easily run the build and tests in the exact same way (toolchain, packages, etc) that is run in CI with one simple command.I removed the Mac build as nix works on Mac so it should be fine. I understand this might just be for developer experience though so I can add that back if needs be.
There are some minor rust formats, I think due to upgrading to a more recent toolchain.